neurogenesis/ngen-weave
Watch
1
0
Fork
You've already forked ngen-weave
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(release): v0.1.2 — deterministic provider failures and two validation regimes #9

Merged
fnoble merged 11 commits from chore/v0.1.2-release into main 2026-08-26 11:33:24 +00:00
Conversation 2 Commits 11 Files changed 20 +547 -26
fnoble commented 2026-08-26 10:56:53 +00:00
Owner
Copy link
No description provided.
chore(release): bump version to 0.1.2
All checks were successful
CI / check (push) Successful in 27s
Details
9439b26b20
fnoble reviewed 2026-08-26 11:05:58 +00:00
fnoble left a comment
Copy link

MEDIUM:
Api config -> raw api strings no mapping
Centralise floating config variable, don't leave it floating mid-script.

MEDIUM: Api config -> raw api strings no mapping Centralise floating config variable, don't leave it floating mid-script.
examples/code_review/models.json Outdated
@ -4,2 +4,3 @@
"example-model": {
"model": "openai/ggml-org/GLM-4.7-Flash-GGUF:Q8_0",
"model": "ggml-org/GLM-4.7-Flash-GGUF:Q8_0",
"api": "openai-compatible",
fnoble commented 2026-08-26 11:03:41 +00:00
Author
Owner
Copy link

api config becomes the regular api prefix (not openai-compatible just 'openai/' or 'openai')

api config becomes the regular api prefix (not openai-compatible just 'openai/' or 'openai')
packages/ngen-weave-core/src/ngen_weave/engine/runner.py Outdated
@ -73,2 +79,4 @@
)
# How much of the last model reply rides an exhausted AgentReplyError message.
REPLY_EXCERPT_CHARS = 500
fnoble commented 2026-08-26 10:59:45 +00:00
Author
Owner
Copy link

Floating config var, needs to be centralised somwehere

Floating config var, needs to be centralised somwehere
fnoble commented 2026-08-26 11:20:35 +00:00
Author
Owner
Copy link

Not quite. Create a constants module for the ngen-weave-core library where values like this are defined and import it here. Do the same for the cli as a placeholder, and add a 'design' doc and add a line to the PRD under decisions.

Not quite. Create a constants module for the ngen-weave-core library where values like this are defined and import it here. Do the same for the cli as a placeholder, and add a 'design' doc and add a line to the PRD under decisions.
packages/ngen-weave-core/src/ngen_weave/models/registry.py Outdated
@ -14,2 +14,4 @@
from ngen_weave.errors import ConfigError, DataError, InfraError, ProviderError
from ngen_weave.models.provider import Completion
API_PREFIXES = {"openai-compatible": "openai/"}
fnoble commented 2026-08-26 11:03:10 +00:00
Author
Owner
Copy link

Remove mapping, leave api config variable as raw api prefix. The most we'll do is check that it ends in '/' ('openai' is ok, just add on the '/' if missing).

Remove mapping, leave api config variable as raw api prefix. The most we'll do is check that it ends in '/' ('openai' is ok, just add on the '/' if missing).
fix(core): take api as raw provider prefix, group runner constants
All checks were successful
CI / check (push) Successful in 26s
Details
7419a84af9 
Review feedback on PR 9:
- models.json api is now the litellm prefix itself ('openai' or
  'openai/'); the API_PREFIXES dialect mapping is gone and validation
  only rejects non-string/empty values.
- Group REPLY_EXCERPT_CHARS with the other module constants in
  runner.py instead of leaving it floating after the imports.
- Bump root pyproject to 0.1.2 (missed in C1).
fnoble reviewed 2026-08-26 11:20:58 +00:00
fnoble left a comment
Copy link

MEDIUM:
See reply to 'floating variable comment'

MEDIUM: See reply to 'floating variable comment'
refactor(core): move shared constants into dedicated constants modules
All checks were successful
CI / check (push) Successful in 26s
Details
c293f2b2e0 
Review feedback on PR 9 (comment 75):
- New ngen_weave.constants holds REPLY_EXCERPT_CHARS; runner.py imports it.
- Placeholder ngen_weave_cli.constants for CLI-wide constants.
- Document the policy in plans/design/constants.md and record the
  decision in the PRD decision log.
fnoble merged commit ae5d1e4676 into main 2026-08-26 11:33:24 +00:00
fnoble deleted branch chore/v0.1.2-release 2026-08-26 11:33:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
neurogenesis/ngen-weave!9
No description provided.